Add assets list #46659
Merged
Add assets list #46659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
|
I see the first element in the tooltip always highlighted on open in Firefox 132 on Ubuntu 20.04 .
|
pierrejeambrun
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Looks good.
I also experience @tirkarthi issue with Chrome on MacOS. Might be worth spending a minute checking if this can be fixed.
pierrejeambrun
force-pushed
the
assets-list
branch
from
b50f631 to
a930209
Compare
|
Had to turn off autoFocus from chakra. (Why would they have that |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Add assets list * AIP-38 Fix import variables * Move popover to component and remove autoFocus --------- Co-authored-by: pierrejeambrun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an initial Assets page with a list of assets and links to their connected tasks and dags:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.