-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5829] Get rid of the checklicence image. #6495
[AIRFLOW-5829] Get rid of the checklicence image. #6495
Conversation
a3e0b43
to
0a4e6b7
Compare
9c794ab
to
3e4348b
Compare
3e4348b
to
24562ff
Compare
c65b53b
to
c9a627a
Compare
c9a627a
to
2f87e82
Compare
This one is green. Looking forward to merging this one as well (getting rid of checklicence image). |
And we have now one static check job in Travis run with single image - less overhead for starting VMs on Travis. See https://travis-ci.org/apache/airflow/builds/607930228 |
Note that this build lasts longer but when we merge to master the image will be pushed to Dockerhub (I will speed it up with my build server in GCP) and they will be much faster (10 minutes each). |
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze.
2f87e82
to
6bd5e9b
Compare
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
This change is a further step of simplifying the set of scripts
used by CI. The separate checklicence image was implemented as an
optimisation of the licence check time. The image to download was
small and could be downloaded slightly faster in CI. However that
made all the management script more complex and lead to having
separate jobs for check licence and static checks. That lead to
actually longer time of Travis jobs - because new machine had to
be spun-off for checklicence check only.
With this change, the CI image is the only one left and it is slightly
bigger (with RAT tool added) but the same image is used for all the
tests - unit tests, static checks and checklicence checks.
This also makes it easier to manage the images and decreases update
overhead on the developers using Breeze.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation