Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-8092] change guava's Optional to java.util in DirectRunner #9431

Merged
merged 1 commit into from
Oct 4, 2019
Merged

[BEAM-8092] change guava's Optional to java.util in DirectRunner #9431

merged 1 commit into from
Oct 4, 2019

Conversation

je-ik
Copy link
Contributor

@je-ik je-ik commented Aug 26, 2019

Removes guava's Optional from DirectRunner runner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@je-ik je-ik requested a review from lukecwik August 26, 2019 12:36
@je-ik
Copy link
Contributor Author

je-ik commented Aug 27, 2019

Retest this please

@je-ik
Copy link
Contributor Author

je-ik commented Aug 27, 2019

Run Direct ValidatesRuner

@je-ik
Copy link
Contributor Author

je-ik commented Aug 27, 2019

Run Direct ValidatesRunner

@aaltay aaltay requested a review from apilloud October 4, 2019 16:21
apilloud
apilloud approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@je-ik
Copy link
Contributor Author

je-ik commented Oct 4, 2019

@apilloud thanks

@je-ik je-ik merged commit ff8653d into apache:master Oct 4, 2019
@je-ik je-ik deleted the BEAM-8092 branch October 4, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apilloud apilloud apilloud approved these changes

@lukecwik lukecwik Awaiting requested review from lukecwik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@je-ik @apilloud