[CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.5, support jdk21 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
commented
Nov 27, 2023
| @@ -16,8 +16,8 @@ | |||
| # | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionSha256Sum=e111cb9948407e26351227dabce49822fb88c37ee72f1d1582a69c68af2e702f | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip | |||
| distributionSha256Sum=3e1af3ae886920c3ac87f7a91f816c0c7c436f276a6eefdb3da152100fef72ae | |||
There was a problem hiding this comment.
taken from https://gradle.org/release-checksums/
snuyanzin
commented
Nov 27, 2023
| @@ -85,9 +85,6 @@ done | |||
| APP_BASE_NAME=${0##*/} | |||
| APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit | |||
|
|
|||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | |||
There was a problem hiding this comment.
every change in this file is a result of command ./gradlew wrapper --gradle-version 8.4
snuyanzin
commented
Nov 27, 2023
| spotbugs.version=3.1.11 | ||
|
|
||
| asm.version=7.1 | ||
| bouncycastle.version=1.70 | ||
| bytebuddy.version=1.14.10 |
There was a problem hiding this comment.
bytebuddy which came with mockito does not support java 21
snuyanzin
changed the title
stoty
approved these changes
Mar 11, 2024
|
Do you plan to merge this @snuyanzin ? |
|
Thanks for the reminder and thanks for the review I just added a note about JDK 21 in I will merge it today |
|
squashed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.