Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Interface mode support (#171) #175

Closed
wants to merge 1 commit into from

Conversation

kwsc98
Copy link

@kwsc98 kwsc98 commented Feb 27, 2024

  • supports interface exposure mode

Ftr: supports interface exposure mode
Add: Add a dubco-macro package
Tst: Add a examples/interface Test

* 20240226

* 20240226

* support interface

---------

Co-authored-by: kwsc98 <[email protected]>
Co-authored-by: kwsc98 <[email protected]>
@@ -1,5 +1,5 @@
Apache Dubbo
Copyright 2018-2024 The Apache Software Foundation
Copyright 2018-2023 The Apache Software Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change

}

pub fn star_matcher(pattern: &str, input: &str) -> bool {
// 将*替换为任意字符的正则表达式
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use english

.map(|routers_service| {
ConditionRouter::new(
Some(routers_service.clone()),
if routers_application_is_null {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码还可以再优化下

)
})
.or_else(|| {
if routers_application_is_null {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

.app_name(app);

if enable_auth.is_some() {
info!("enable nacos auth!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码可以删除,感觉没必要

Some(config)
}
Err(_) => {
info!("failed to parse {}Router rule", config_type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日志加个异常吧,别用info

@baerwang baerwang added the enhancement New feature or request label Feb 27, 2024
@kwsc98 kwsc98 closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants