-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Interface mode support (#171) #175
Conversation
* 20240226 * 20240226 * support interface --------- Co-authored-by: kwsc98 <[email protected]> Co-authored-by: kwsc98 <[email protected]>
@@ -1,5 +1,5 @@ | |||
Apache Dubbo | |||
Copyright 2018-2024 The Apache Software Foundation | |||
Copyright 2018-2023 The Apache Software Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to change
} | ||
|
||
pub fn star_matcher(pattern: &str, input: &str) -> bool { | ||
// 将*替换为任意字符的正则表达式 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use english
.map(|routers_service| { | ||
ConditionRouter::new( | ||
Some(routers_service.clone()), | ||
if routers_application_is_null { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段代码还可以再优化下
) | ||
}) | ||
.or_else(|| { | ||
if routers_application_is_null { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
.app_name(app); | ||
|
||
if enable_auth.is_some() { | ||
info!("enable nacos auth!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段代码可以删除,感觉没必要
Some(config) | ||
} | ||
Err(_) => { | ||
info!("failed to parse {}Router rule", config_type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
日志加个异常吧,别用info
Ftr: supports interface exposure mode
Add: Add a dubco-macro package
Tst: Add a examples/interface Test