Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25674] Add drop tables to be idempotent in case of retrials and the related test #18429

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

echauchot
Copy link
Contributor

This is to avoid the flakiness of the CassandraConnectorITCase#test*Pojo* tests due to retrials that try to recreate an already created (and potentially populated) table. This is the quick version that still uses Junit4 and RetryRule to quickly fix the Cassandra flakiness issue. The version that uses RetryExtension needs a migration of cassandra tests to junit5 and some parent tests are in flink-streaming and mutualized so it would be done in a next PR.

I also added a commit to replace all string literals by constants to avoid existing copy/paste.

R: @tillrohrmann
CC: @zentol

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4db6e9c (Thu Jan 20 16:23:03 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 20, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol zentol self-assigned this Jan 21, 2022
@zentol zentol merged commit 6c84a5b into apache:master Jan 21, 2022
@echauchot
Copy link
Contributor Author

Thanks @zentol for quick review/merge. Time to monitor flakiness now 😄

@echauchot echauchot deleted the FLINK-25674-already-exists branch January 21, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants