Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LGTM gripes - DO NOT REVIEW #508

Closed
wants to merge 7 commits into from

Conversation

pdxcodemonkey
Copy link
Contributor

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2019

This pull request fixes 7 alerts when merging 2f4f02b into 01bd930 - view on LGTM.com

fixed alerts:

  • 5 for Wrong type of arguments to formatting function
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2019

This pull request introduces 1 alert and fixes 40 when merging a053459 into 01bd930 - view on LGTM.com

new alerts:

  • 1 for Wrong type of arguments to formatting function

fixed alerts:

  • 37 for Wrong type of arguments to formatting function
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides parameter
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2019

This pull request fixes 55 alerts when merging 036a82d into 01bd930 - view on LGTM.com

fixed alerts:

  • 52 for Wrong type of arguments to formatting function
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides parameter
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2019

This pull request fixes 88 alerts when merging faadc4e into 01bd930 - view on LGTM.com

fixed alerts:

  • 81 for Wrong type of arguments to formatting function
  • 3 for Container contents are never accessed
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides parameter
  • 1 for Invalid format string
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2019

This pull request fixes 88 alerts when merging a2ab466 into 01bd930 - view on LGTM.com

fixed alerts:

  • 81 for Wrong type of arguments to formatting function
  • 3 for Container contents are never accessed
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides parameter
  • 1 for Invalid format string
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2019

This pull request fixes 87 alerts when merging d834284 into d9c3039 - view on LGTM.com

fixed alerts:

  • 80 for Wrong type of arguments to formatting function
  • 3 for Container contents are never accessed
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides parameter
  • 1 for Invalid format string
  • 1 for Useless assignment to local variable

@pdxcodemonkey
Copy link
Contributor Author

Will reopen as new PR with associated JIRA item.

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2019

This pull request fixes 5 alerts when merging 2e1afe2 into 9b1c5ab - view on LGTM.com

fixed alerts:

  • 3 for Container contents are never accessed
  • 1 for Invalid format string
  • 1 for Useless assignment to local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant