GEODE-9559: demacroize clicache #862
Conversation
- _GF_MG_EXCEPTION_TRY2 - _GF_MG_EXCEPTION_CATCH_ALL2
|
The procedure for this PR consisted of cutting/pasting the original macro invocations with the corresponding preprocessor output. Although there are quite a few files involved, the changes are basically all the same. For this reason it seemed prudent to submit this as a single PR. |
Is there a way to get the preprocessor to do this for you for specific macros only and then preserve that output so we can be certain there are not copy/paste errors? |
|
Although Microsoft has a new preprocessor that follows the standard (I didn't even know there was a standard), it doesn't appear to allow enabling/disabling specific macro expansion. However, I'm not too worried about copy/paste errors here. The compiler and subsequent clicache tests should catch any errors. |
jake-at-work
dismissed
their stale review
I don't have the time to review. I will just remove my block.
|
Closing this PR since it doesn't add new functionality or fix an existing bug. For anyone interested in decompiling the C++/CLI code they can checkout my branch: mmartell:GEODE-9559-demacroize-clicache |
Macros in C++ complicate debug efforts and code maintenance and are generally considered old school. This PR is to remove all the complicated macros in the .NET Framework client, e.g. the clicache module.
In addition to improving the maintainability of the clicache module, removing the macros will greatly assist the creation of the .NET Core client. dotPeek is proving to be a valuable tool in the .NET Core project, but is currently limited by the extensive use of macros in the clicache code.