GEODE-9569: Native client UG build script keeps doc after generating it #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @alb3rtobr. I'm reviewing as my schedule permits, may take another day. Thanks for your patience. |
davebarnes97
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Script works like a champ - thanks!
The README file looks fine in GetHub's MarkDown. As a courtesy to those who use other flavors (in my case MacDown), I've attached a lightly-edited version that introduces some whitespace that improves the formatting (and tweaks a bit of grammar at the same time).
Whether you want to use this is your option. I approve the PR with or without the README changes
GEODE-9569-README.diff.zip
.
|
@alb3rtobr I will leave it to you to merge the PR, back-port if desired, and handle the JIRA ticket. Thanks again! |
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UG build script allows to preview the user guide but the generated files are deleted as they are created inside a container.
This PR causes the generated files are not deleted after the script ends.