GEODE-10292: Bump to boost 1.79.0 #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI didn't run at all. Post an empty commit and see if it runs. |
|
surprised at the sad time for windows. I thought on my windows 10/vs2019 personal machine things were fine, but guess will have to check again |
jake-at-work
approved these changes
Jun 18, 2022
|
ok I think the problem is _WIN32_WINNT needs to be updated, but I don't quite understand why bumping boost would require changing what windows version to target |
|
Hello Michael, Any plan when this will be merged? Thanks! |
|
Probably not anytime soon as I haven't made time to to figure out this problem. Will close the PR since I'm not making progress on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially complained that it did not know what
boost::filesystem::ofstreambefore adding the header file