-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HADOOP-13546. Override equals and hashCode of the default retry polic…
…y to avoid connection leakage. Contributed by Xiaobing Zhou.
- Loading branch information
Showing
5 changed files
with
431 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154 changes: 154 additions & 0 deletions
154
...ect/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestConnectionRetryPolicy.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.io.retry; | ||
|
|
||
| import static org.junit.Assert.*; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.PathIOException; | ||
| import org.apache.hadoop.ipc.RemoteException; | ||
| import org.apache.hadoop.ipc.RetriableException; | ||
| import org.apache.hadoop.ipc.RpcNoSuchMethodException; | ||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * This class mainly tests behaviors of various retry policies in connection | ||
| * level. | ||
| */ | ||
| public class TestConnectionRetryPolicy { | ||
| private static RetryPolicy getDefaultRetryPolicy( | ||
| final boolean defaultRetryPolicyEnabled, | ||
| final String defaultRetryPolicySpec, | ||
| final String remoteExceptionToRetry) { | ||
| return getDefaultRetryPolicy( | ||
| new Configuration(), | ||
| defaultRetryPolicyEnabled, | ||
| defaultRetryPolicySpec, | ||
| remoteExceptionToRetry); | ||
| } | ||
|
|
||
| private static RetryPolicy getDefaultRetryPolicy( | ||
| final boolean defaultRetryPolicyEnabled, | ||
| final String defaultRetryPolicySpec) { | ||
| return getDefaultRetryPolicy( | ||
| new Configuration(), | ||
| defaultRetryPolicyEnabled, | ||
| defaultRetryPolicySpec, | ||
| ""); | ||
| } | ||
|
|
||
| public static RetryPolicy getDefaultRetryPolicy( | ||
| final Configuration conf, | ||
| final boolean defaultRetryPolicyEnabled, | ||
| final String defaultRetryPolicySpec, | ||
| final String remoteExceptionToRetry) { | ||
| return RetryUtils.getDefaultRetryPolicy( | ||
| conf, | ||
| "org.apache.hadoop.io.retry.TestConnectionRetryPolicy.No.Such.Key", | ||
| defaultRetryPolicyEnabled, | ||
| "org.apache.hadoop.io.retry.TestConnectionRetryPolicy.No.Such.Key", | ||
| defaultRetryPolicySpec, | ||
| ""); | ||
| } | ||
|
|
||
| @Test(timeout = 60000) | ||
| public void testDefaultRetryPolicyEquivalence() { | ||
| RetryPolicy rp1 = null; | ||
| RetryPolicy rp2 = null; | ||
| RetryPolicy rp3 = null; | ||
|
|
||
| /* test the same setting */ | ||
| rp1 = getDefaultRetryPolicy(true, "10000,2"); | ||
| rp2 = getDefaultRetryPolicy(true, "10000,2"); | ||
| rp3 = getDefaultRetryPolicy(true, "10000,2"); | ||
| verifyRetryPolicyEquivalence(new RetryPolicy[] {rp1, rp2, rp3}); | ||
|
|
||
| /* test different remoteExceptionToRetry */ | ||
| rp1 = getDefaultRetryPolicy( | ||
| true, | ||
| "10000,2", | ||
| new RemoteException( | ||
| PathIOException.class.getName(), | ||
| "path IO exception").getClassName()); | ||
| rp2 = getDefaultRetryPolicy( | ||
| true, | ||
| "10000,2", | ||
| new RemoteException( | ||
| RpcNoSuchMethodException.class.getName(), | ||
| "no such method exception").getClassName()); | ||
| rp3 = getDefaultRetryPolicy( | ||
| true, | ||
| "10000,2", | ||
| new RemoteException( | ||
| RetriableException.class.getName(), | ||
| "retriable exception").getClassName()); | ||
| verifyRetryPolicyEquivalence(new RetryPolicy[] {rp1, rp2, rp3}); | ||
|
|
||
| /* test enabled and different specifications */ | ||
| rp1 = getDefaultRetryPolicy(true, "20000,3"); | ||
| rp2 = getDefaultRetryPolicy(true, "30000,4"); | ||
| assertNotEquals("should not be equal", rp1, rp2); | ||
| assertNotEquals( | ||
| "should not have the same hash code", | ||
| rp1.hashCode(), | ||
| rp2.hashCode()); | ||
|
|
||
| /* test disabled and the same specifications */ | ||
| rp1 = getDefaultRetryPolicy(false, "40000,5"); | ||
| rp2 = getDefaultRetryPolicy(false, "40000,5"); | ||
| assertEquals("should be equal", rp1, rp2); | ||
| assertEquals( | ||
| "should have the same hash code", | ||
| rp1, rp2); | ||
|
|
||
| /* test the disabled and different specifications */ | ||
| rp1 = getDefaultRetryPolicy(false, "50000,6"); | ||
| rp2 = getDefaultRetryPolicy(false, "60000,7"); | ||
| assertEquals("should be equal", rp1, rp2); | ||
| assertEquals( | ||
| "should have the same hash code", | ||
| rp1, rp2); | ||
| } | ||
|
|
||
| public static RetryPolicy newTryOnceThenFail() { | ||
| return new RetryPolicies.TryOnceThenFail(); | ||
| } | ||
|
|
||
| @Test(timeout = 60000) | ||
| public void testTryOnceThenFailEquivalence() throws Exception { | ||
| final RetryPolicy rp1 = newTryOnceThenFail(); | ||
| final RetryPolicy rp2 = newTryOnceThenFail(); | ||
| final RetryPolicy rp3 = newTryOnceThenFail(); | ||
| verifyRetryPolicyEquivalence(new RetryPolicy[] {rp1, rp2, rp3}); | ||
| } | ||
|
|
||
| private void verifyRetryPolicyEquivalence(RetryPolicy[] polices) { | ||
| for (int i = 0; i < polices.length; i++) { | ||
| for (int j = 0; j < polices.length; j++) { | ||
| if (i != j) { | ||
| assertEquals("should be equal", polices[i], polices[j]); | ||
| assertEquals( | ||
| "should have the same hash code", | ||
| polices[i].hashCode(), | ||
| polices[j].hashCode()); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.