-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17432. Fix junit dependency to enable JUnit4 tests to run in hadoop-hdfs-rbf #6639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, pending CI
💔 -1 overall
This message was automatically generated. |
@dineshchitlangia Thanks for your review. But the failed tests may be related. I will investigate it. |
The failed tests are caused by HDFS-17354. I created HDFS-17435 for addressing the issue. This PR doesn't cause the failed tests. So I'm merging it. |
Thanks again for your review, @dineshchitlangia. |
…oop-hdfs-rbf (#6639) Reviewed-by: Dinesh Chitlangia <[email protected]> (cherry picked from commit adab3a2)
Description of PR
After HDFS-17370, JUnit4 tests stopped running in hadoop-hdfs-rbf. To enable both JUnit4 and JUnit5 tests to run, we need to add junit-vintage-engine to the hadoop-hdfs-rbf/pom.xml.
How was this patch tested?
I confirmed that all unit tests in hadoop-hdfs-rbf ran with this change with
cd hadoop-hdfs-project/hadoop-hdfs-rbf && mvn clean test -fae
in my local laptop.For code changes: