Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: Allow Equality Deletes with Row Lineage and Define Behavior #12230

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Spec: Allow Equality Deletes with Row Lineage and Define Behavior #12230

merged 3 commits into from
Feb 24, 2025
+1 −2

Conversation

RussellSpitzer
Copy link
Member

No description provided.

@github-actions github-actions bot added the Specification Issues that may introduce spec changes. label Feb 11, 2025
stevenzwu
stevenzwu reviewed Feb 12, 2025
View reviewed changes
pvary
pvary reviewed Feb 12, 2025
View reviewed changes
@RussellSpitzer RussellSpitzer force-pushed the EquaRowLin branch 2 times, most recently from 36c95ae to 5a9a136 Compare February 12, 2025 20:48
@RussellSpitzer
Copy link
Member Author

@stevenzwu , @pvary + @singhpk234 - Wording Updated

singhpk234
singhpk234 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you @RussellSpitzer !

stevenzwu
stevenzwu approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@stevenzwu stevenzwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

To me, this is just a different wording of essentially the same result. Row lineage is still broken and has a different semantics for updates made via equality deletes.

pvary
pvary reviewed Feb 13, 2025
View reviewed changes
aokolnychyi
aokolnychyi reviewed Feb 21, 2025
View reviewed changes
@RussellSpitzer RussellSpitzer merged commit 8844508 into apache:main Feb 24, 2025
2 checks passed
@RussellSpitzer RussellSpitzer deleted the EquaRowLin branch February 24, 2025 18:55
@RussellSpitzer
Copy link
Member Author

Merged! Thanks everyone - @aokolnychyi , @rdblue , @huaxingao , @Fokko , @pvary , @stevenzwu , @singhpk234 for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aokolnychyi aokolnychyi aokolnychyi left review comments

@rdblue rdblue rdblue approved these changes

@Fokko Fokko Fokko approved these changes

@stevenzwu stevenzwu stevenzwu approved these changes

@huaxingao huaxingao huaxingao approved these changes

@pvary pvary pvary approved these changes

@singhpk234 singhpk234 singhpk234 approved these changes

Assignees
No one assigned
Labels
Specification Issues that may introduce spec changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RussellSpitzer @rdblue @Fokko @stevenzwu @aokolnychyi @huaxingao @pvary @singhpk234