Fixes and adds configurability to test_spark_sql_s3_with_privileges.py regtest #1060
+99
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis-bowen
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
travis-bowen
commented
Feb 27, 2025
|
|
||
| rotate_credentials = rotate_api.rotate_credentials(principal_name=principal_name) | ||
| return rotate_credentials | ||
| except ApiException as e: |
There was a problem hiding this comment.
removed since the catch block logic relies on rotate_client and rotate_client is only set in the try block so will generally be unset in the catch.
| Used to provide a path prefix between the port number and the standard polaris endpoint paths | ||
| :return: | ||
| """ | ||
| return os.getenv('POLARIS_PATH_PREFIX', '') |
There was a problem hiding this comment.
It looks like this is expected to begin with / but to never end with it, while polaris_url_scheme and polaris_host are the opposite?
There was a problem hiding this comment.
Yeah - you're right - there's some inconsistencies.
Polaris_Host => no leading or trailing /
AWS_Bucket_Prefix = > No leading or trailing /
URL Schema => Updated to not have leading or trailing /
POLARIS_PATH_PREFIX => Now also updated to not have a leading or trailing / (the callsites that use it can determine whether to add those)
eric-maynard
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Achieves the following:
1.) Fixes tests that currently fail
2.) Makes the REGTEST_ROOT_BEARER_TOKEN able to be passed in vs. instantiated from root, which can be used for instance to execute this test on long standing instances
3.) Allows an optional AWS_BUCKET_BASE_LOCATION_PREFIX to be passed in as well. This can also be useful for running against a long standing instance.
Here's the failed output on main.
And the success after this PR:
