Have the ability to send log messages to a topic in Python #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Mar 7, 2018
merlimat
reviewed
Mar 7, 2018
| str(topic_name), | ||
| block_if_queue_full=True, | ||
| batching_enabled=True, | ||
| batching_max_publish_delay_ms=1, |
There was a problem hiding this comment.
We could use bigger timeout 10ms or even 100ms, since this is not latency sensitive, to improve efficiency.
There was a problem hiding this comment.
Also we should enable LZ4 compression by default. It's very light on cpu and provides good compression for basic text
| block_if_queue_full=True, | ||
| batching_enabled=True, | ||
| batching_max_publish_delay_ms=1, | ||
| max_pending_messages=100000) |
There was a problem hiding this comment.
100K messages could mean a lot of memory to buffer up, I'd stick with default 1K unless there are specific needs
|
@merlimat addressed review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to allow users to specify a log topic where all function logging should end up in.
This change is the first among a series of upcoming change to make that happen. Specifically this change adds the log handler in python
Modifications
Describe the modifications you've done.
Result
After your change, what will change.