Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][io] Allow skipping connector deployment #23932

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

nodece
Copy link
Member

@nodece nodece commented Feb 6, 2025

Motivation

By default, Pulsar uploads connector JAR and NAR files to Maven Central, but this is unnecessary since connectors are not typically downloaded from Maven Central. Additionally, the large size of the connector files causes timeouts or connection disconnections during the deployment process, as the files exceed Sonatype's size limitations for private publishing.

Central Publisher Portal currently supports common archive extensions, e.g. zip, jar, tar.gz. While you can only upload one zip at a time per publishing request, the archive can contain more than one component. You can upload an archive up to 1GB in size. If your upload fails with an error or does not result in the creation of a deployment first check to see if the file is less than 1GB in size and that it extracts properly with a local archive extract tool. If the archive is valid and fits into the size limit but still won't upload please email Central Support and provide as much supporting information as you can (e.g. screenshots, logs, steps to reproduce).

Modifications

  • Add the skipDeployConnector property to skip connector deployment.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 6, 2025
@nodece nodece changed the title [improve][io] Allow skipping deployment connector [improve][io] Allow skipping connector deployment Feb 6, 2025
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, need more review

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece
Copy link
Member Author

nodece commented Feb 8, 2025

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (bbc6224) to head (6a6efde).
Report is 886 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23932      +/-   ##
============================================
+ Coverage     73.57%   74.21%   +0.64%     
+ Complexity    32624     2374   -30250     
============================================
  Files          1877     1853      -24     
  Lines        139502   143726    +4224     
  Branches      15299    16333    +1034     
============================================
+ Hits         102638   106673    +4035     
+ Misses        28908    28642     -266     
- Partials       7956     8411     +455     
Flag Coverage Δ
inttests 26.67% <ø> (+2.08%) ⬆️
systests 23.17% <ø> (-1.15%) ⬇️
unittests 73.74% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1032 files with indirect coverage changes

@dao-jun dao-jun merged commit e6cfd2b into apache:master Feb 8, 2025
58 of 59 checks passed
@nodece nodece deleted the allow-skipping-deployment-connector branch February 8, 2025 06:16
@nodece nodece self-assigned this Feb 8, 2025
@nodece nodece added this to the 4.1.0 milestone Feb 8, 2025
nodece added a commit to ascentstream/pulsar that referenced this pull request Feb 8, 2025
lhotari pushed a commit that referenced this pull request Feb 8, 2025
Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit e6cfd2b)
lhotari pushed a commit that referenced this pull request Feb 8, 2025
Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit e6cfd2b)
lhotari pushed a commit that referenced this pull request Feb 8, 2025
Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit e6cfd2b)
nodece added a commit to ascentstream/pulsar that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants