-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][io] Allow skipping connector deployment #23932
[improve][io] Allow skipping connector deployment #23932
Conversation
Signed-off-by: Zixuan Liu <[email protected]>
02fd5ac
to
6a6efde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, need more review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23932 +/- ##
============================================
+ Coverage 73.57% 74.21% +0.64%
+ Complexity 32624 2374 -30250
============================================
Files 1877 1853 -24
Lines 139502 143726 +4224
Branches 15299 16333 +1034
============================================
+ Hits 102638 106673 +4035
+ Misses 28908 28642 -266
- Partials 7956 8411 +455
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit e6cfd2b)
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit e6cfd2b)
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit e6cfd2b)
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit e6cfd2b)
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit e6cfd2b)
Motivation
By default, Pulsar uploads connector JAR and NAR files to Maven Central, but this is unnecessary since connectors are not typically downloaded from Maven Central. Additionally, the large size of the connector files causes timeouts or connection disconnections during the deployment process, as the files exceed Sonatype's size limitations for private publishing.
Modifications
skipDeployConnector
property to skip connector deployment.Documentation
doc
doc-required
doc-not-needed
doc-complete