Allow byte[] keys for messages (#1016) #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it can be useful to send something more complex than a string as the key of the message. However, early on Pulsar chose to make String the only way to send a key, and this permeates throughout the code, so we can't very well change it now. This patch adds rudamentary byte[] key support. If a user adds a byte[] key, the byte[] is base64 encoded and stored in the normal key field. We also send a flag to denote that it is base64 encoded, so the receiving end knows to decode it correct. There's no schema or anything attached to this. Any SerDe has to be handled manually by the client.
ivankelly
added
area/client
type/enhancement
sijie
reviewed
Sep 19, 2018
| * | ||
| * @param key routing key for message, in byte array form | ||
| */ | ||
| TypedMessageBuilder<T> keyBytes(byte[] key); |
There was a problem hiding this comment.
any particular reason on naming this keyBytes instead of key?
There was a problem hiding this comment.
symmetry with the getKeyBytes() call on Message.
sijie
approved these changes
Sep 20, 2018
|
rerun integration tests |
|
run java8 tests |
2 similar comments
|
run java8 tests |
|
run java8 tests |
jiazhai
approved these changes
Sep 27, 2018
|
rerun java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it can be useful to send something more complex than a
string as the key of the message. However, early on Pulsar chose to
make String the only way to send a key, and this permeates throughout
the code, so we can't very well change it now.
This patch adds rudimentary byte[] key support. If a user adds a
byte[] key, the byte[] is base64 encoded and stored in the normal key
field. We also send a flag to denote that it is base64 encoded, so the
receiving end knows to decode it correctly. There's no schema or
anything attached to this. Any SerDe has to be handled manually by the
client.