[ISSUE #7699] Add namespace v2 in client #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpmma
force-pushed
the
feature/namespace-v2
branch
from
dfb26ae to
710d3bc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7700 +/- ##
=============================================
- Coverage 43.17% 43.15% -0.02%
- Complexity 9797 9820 +23
=============================================
Files 1165 1167 +2
Lines 84477 84595 +118
Branches 10966 10984 +18
=============================================
+ Hits 36474 36509 +35
- Misses 43473 43551 +78
- Partials 4530 4535 +5 ☔ View full report in Codecov by Sentry. |
lizhanhui
reviewed
Jan 2, 2024
| @@ -1377,7 +1377,7 @@ public CompletableFuture<PullResult> pullMessageFromSpecificBrokerAsync(String b | |||
| requestHeader.setSubVersion(System.currentTimeMillis()); | |||
| requestHeader.setMaxMsgBytes(Integer.MAX_VALUE); | |||
| requestHeader.setExpressionType(ExpressionType.TAG); | |||
| requestHeader.setBname(brokerName); | |||
There was a problem hiding this comment.
This shall result in a backward compatible issue.
There was a problem hiding this comment.
Only the function signature has been modified here, without changes to the internal fields. The field name remains 'bname', so there should be no compatibility issues.
There was a problem hiding this comment.
RongtongJin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7699
Brief Description
Add namespace v2 in client
How Did You Test This Change?