Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAMZA-2575] Fix the flatten output values and add more tests #1409

Merged
merged 1 commit into from
Aug 5, 2020
Merged

[SAMZA-2575] Fix the flatten output values and add more tests #1409

merged 1 commit into from
Aug 5, 2020

Conversation

b-slim
Copy link
Contributor

@b-slim b-slim commented Aug 4, 2020

Currently: Flatten udf return a wrong type

SELECT FLATTEN(ARRYA[1,2]), 'value' form table;
-- expected result is 
1,value
2,value
-- current result is 
[1],value
[2],value

Fix: return the actual inner value and add more tests

@b-slim b-slim force-pushed the SAMZA-2575-fix-flatten branch from a71c171 to a2ae7bc Compare August 4, 2020 20:17
atoomula
atoomula approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@atoomula atoomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoomula atoomula merged commit 5c4834e into apache:master Aug 5, 2020
lakshmi-manasa-g pushed a commit to lakshmi-manasa-g/samza that referenced this pull request Feb 9, 2021
@b-slim @lakshmi-manasa-g
SAMZA-2575: Fix the flatten output values and add more tests (apache#…
b73df6e 
…1409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoomula atoomula atoomula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-slim @atoomula