-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-707] Refactor rasterization process and add allTouched parameter for rasterization functions #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/src/test/java/org/apache/sedona/common/raster/RasterConstructorsTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overall idea of implementing rasterization on our own instead of relying on GeoTools' VectorToRasterProcess
as well as Java AWT's Graphics2D. I've left some comments regarding the implementation of various rasterization functions.
common/src/main/java/org/apache/sedona/common/raster/Rasterization.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/sedona/common/raster/Rasterization.java
Outdated
Show resolved
Hide resolved
…add-all_touched-parameter
Kontinuation
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
Fixes #1715
Affects API of downstream RS_Functions, introduces
allTouched
mode to:RS_ZonalStatsAll
&RS_ZonalStats
RS_Clip
RS_AsRaster
RS_SetValues
Algorithm Overview
The algorithm is inspired by GDAL’s
GDALdllImageFilledPolygon
but is implemented in Java with optimizations for duplicate handling, centroid-based inclusion, and allTouched behavior.The rasterization process follows two main strategies:
allTouched
mode for including all pixels touched by the polygon.How was this patch tested?
Polygons
Did this PR include necessary documentation updates?
vX.Y.Z
format.