Patch FPM Build Script #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tags A mixture of inconsistent testing and dependencies led to some weird errors that were hard to reproduce. I cordoned it down to: - Ordering of --depends calls, where calling python3-pip before python3-stomppy led to an almost instant fail - Bad module names It was not in fact the ifs that were at fault. This script has now been tested with Rocky 8 and CentOS 8 from start to finish, and Debian previously. It will now be tested with EL7.
Fixes incompatibility with EL7 by changing some module names.
tofu-rocketry
requested changes
Feb 19, 2024
Co-authored-by: Adrian Coveney <[email protected]>
Co-authored-by: Adrian Coveney <[email protected]>
tofu-rocketry
approved these changes
Feb 21, 2024
|
Packages building and installing on EL 7 and 8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #301
Renames the buildscript, updates dependencies, dependency orders and also adds a 2x2 matrix for el7/el8 vs debian builds for python 2 and 3.