Release 3.4.0 to master #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 3.3.1 to dev
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v5.0.0...v5.1.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.1.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3.1.3...v4.1.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.1.0 to 4.2.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.1.0...v4.2.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.2.0...v4.3.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
It's reccomended to add 'yum clean all' to each Docker RUN that does a yum install to keep the image size down.
- Change comment spacing to standard 2 before mark - Change pyopenssl requirement to all lowercase
- Reorder imports to alphabetical order - Change multi-line import to use implicit continuation
While it may be a useful function elsewhere in future, it's not currently used outside its own module, so mark is as private. This can allow us to refactor without worrying about anything other than the tests.
OpenSSL compatibility fix
Structuring
- Adds cryptography as a dependency before pyopenssl - Modified pyopenssl to lower case to satisfy pip call
FPM build script for RPM and DEB
- Set AMS as default messaging system. - Add AMS hosts (both prod and devel) as options. - Emphasise note about the server_cert. - Add token as commented out option. - Copy log level comments from sender to receiver conf.
- Get rid of placeholder receiver destination. People using this option should only be accounting repository admins so will know where they need to connect to. - Make the receiver and sender config match a little better. - Remove port number from sender config as option is generally less likely to be used with AMS being more common.
Update comments and options in config files
We don't (yet) want to test against unicode.
Some compatability issues raised in testing with 3.3.0
- Add decoding when sending messages to fix Python 3 issues. - Set both to ascii only as this maintains the behaviour with Python 2 for now while in transition period.
- Set pyopenssl >=19.1 so that it is compatable with cryptography >=3.3.0 - Revert cryptography requriement to 3.3
Pin to 3.3.2, the latest version that's still compatible with Python 2.
Character vs. byte strings fix
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…tags A mixture of inconsistent testing and dependencies led to some weird errors that were hard to reproduce. I cordoned it down to: - Ordering of --depends calls, where calling python3-pip before python3-stomppy led to an almost instant fail - Bad module names It was not in fact the ifs that were at fault. This script has now been tested with Rocky 8 and CentOS 8 from start to finish, and Debian previously. It will now be tested with EL7.
Fixes incompatibility with EL7 by changing some module names.
Co-authored-by: Adrian Coveney <[email protected]>
Co-authored-by: Adrian Coveney <[email protected]>
Patch FPM Build Script
RedProkofiev
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #305 for new changes not already reviewed.