Add resilience to installation status watch (kyma-project#517)

Failing to connect to the cluster no longer terminates the watch. Instead, it will attempt reattaching after 10 seconds periodically. Signed-off-by: Borja Clemente <[email protected]>
aphougat · Jul 23, 2020 · 2cc5d04 · 2cc5d04
1 parent 9d6e284
commit 2cc5d04
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/pkg/installation/installation.go b/pkg/installation/installation.go
@@ -385,19 +385,19 @@ func (i *Installation) waitForInstaller() error {
 		default:
 			installationState, err := i.service.CheckInstallationState(i.k8s.Config())
 			if err != nil {
-				installErr := installationSDK.InstallationError{}
-				if errors.As(err, &installErr) {
-					if !errorOccured {
-						errorOccured = true
+				if !errorOccured {
+					errorOccured = true
+					installErr := installationSDK.InstallationError{}
+					if errors.As(err, &installErr) {
 						i.currentStep.LogErrorf("%s, which may be OK. Will retry later...", installErr.Error())
 						i.currentStep.LogInfo("To fetch the error logs from the installer, run: kubectl get installation kyma-installation -o go-template --template='{{- range .status.errorLog }}{{printf \"%s:\\n %s\\n\" .component .log}}{{- end}}'")
 						i.currentStep.LogInfo("To fetch the application logs from the installer, run: kubectl logs -n kyma-installer -l name=kyma-installer")
+					} else {
+						i.currentStep.LogErrorf("Failed to get installation state, which may be OK. Will retry later...\nError: %s", err)
 					}
-					time.Sleep(10 * time.Second)
-					continue
-				} else {
-					return fmt.Errorf("Failed to get installation state: %s", err.Error())
 				}
+				time.Sleep(10 * time.Second)
+				continue
 			}
 
 			switch installationState.State {