Add tests for installation (kyma-project#530)

pkg/installation/installation_test.go

@@ -0,0 +1,203 @@
+package installation
+
+import (
+	"errors"
+	"os"
+	"testing"
+	"time"
+
+	installSDK "github.com/kyma-incubator/hydroform/install/installation"
+	k8sMocks "github.com/kyma-project/cli/internal/kube/mocks"
+	"github.com/kyma-project/cli/pkg/installation/mocks"
+	"github.com/kyma-project/kyma/components/api-controller/pkg/apis/networking.istio.io/v1alpha3"
+	fakeIstio "github.com/kyma-project/kyma/components/api-controller/pkg/clients/networking.istio.io/clientset/versioned/fake"
+	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
+	v1 "k8s.io/api/core/v1"
+	metaV1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/kubernetes/fake"
+	"k8s.io/client-go/rest"
+)
+
+func TestInstallKyma(t *testing.T) {
+	// prepare mocks
+	kymaMock := k8sMocks.KymaKube{}
+	iServiceMock := mocks.Service{}
+
+	// fake k8s with installer pod running and post installation resources
+	k8sMock := fake.NewSimpleClientset(
+		&v1.Pod{
+			ObjectMeta: metaV1.ObjectMeta{Name: "kyma-installer", Namespace: "kyma-installer", Labels: map[string]string{"name": "kyma-installer"}},
+			Status:     v1.PodStatus{Phase: v1.PodRunning},
+			Spec: v1.PodSpec{
+				Containers: []v1.Container{
+					{
+						Name:  "Installer",
+						Image: "fake-registry/installer:1.11.0",
+					},
+				},
+			},
+		},
+		&v1.Secret{
+			ObjectMeta: metaV1.ObjectMeta{
+				Name:      "admin-user",
+				Namespace: "kyma-system",
+			},
+			Data: map[string][]byte{
+				"email":    []byte("[email protected]"),
+				"password": []byte("1234-super-secure"),
+			},
+		},
+	)
+
+	// fake istio vService
+	istioMock := fakeIstio.NewSimpleClientset(
+		&v1alpha3.VirtualService{
+			ObjectMeta: metaV1.ObjectMeta{
+				Name:      "console-web",
+				Namespace: "kyma-system",
+			},
+			Spec: &v1alpha3.VirtualServiceSpec{
+				Hosts: []string{"fake-console-url"},
+			},
+		},
+	)
+
+	i := &Installation{
+		K8s:     &kymaMock,
+		Service: &iServiceMock,
+		Options: &Options{
+			NoWait:           false,
+			NonInteractive:   true,
+			Timeout:          10 * time.Minute,
+			Domain:           "irrelevant",
+			TLSCert:          "fake-cert",
+			TLSKey:           "fake-key",
+			Password:         "fake-password",
+			OverrideConfigs:  nil,
+			ComponentsConfig: "",
+			IsLocal:          false,
+			Source:           "1.11.0",
+		},
+	}
+
+	kymaMock.On("Static").Return(k8sMock)
+	kymaMock.On("Istio").Return(istioMock)
+	kymaMock.On("Config", mock.Anything).Return(&rest.Config{Host: "fake-kubeconfig-host"})
+
+	// There is an existing installation
+	iServiceMock.On("CheckInstallationState", mock.Anything).Return(installSDK.InstallationState{State: "Installed"}, nil).Once()
+
+	r, err := i.InstallKyma()
+	require.NoError(t, err)
+	require.NotEmpty(t, r)
+
+	// Installation in progress
+	i.Options.NoWait = true // no need to wait for installation here
+	iServiceMock.On("CheckInstallationState", mock.Anything).Return(installSDK.InstallationState{State: "InProgress"}, nil).Times(2)
+
+	r, err = i.InstallKyma()
+	require.NoError(t, err)
+	require.Empty(t, r)
+
+	// Error getting installation status
+	iServiceMock.On("CheckInstallationState", mock.Anything).Return(installSDK.InstallationState{}, errors.New("installation is hiding from us")).Once()
+
+	r, err = i.InstallKyma()
+	require.Error(t, err)
+	require.Empty(t, r)
+
+	// Empty installation status
+	iServiceMock.On("CheckInstallationState", mock.Anything).Return(installSDK.InstallationState{}, nil).Once()
+
+	r, err = i.InstallKyma()
+	require.Error(t, err)
+	require.Empty(t, r)
+
+	// Happy path
+	iServiceMock.On("CheckInstallationState", mock.Anything).Return(installSDK.InstallationState{State: installSDK.NoInstallationState}, nil).Once()
+	iServiceMock.On("TriggerInstallation", mock.Anything, mock.Anything, mock.Anything).Return(nil)
+	iServiceMock.On("CheckInstallationState", mock.Anything).Return(installSDK.InstallationState{State: "Installed"}, nil).Once()
+	kymaMock.On("WaitPodStatusByLabel", "kyma-installer", "name", "kyma-installer", v1.PodRunning).Return(nil)
+
+	r, err = i.InstallKyma()
+	require.NoError(t, err)
+	require.NotEmpty(t, r)
+}
+
+func TestValidateConfigurations(t *testing.T) {
+	// Domain is passed, but certificate and key are missing
+	i := &Installation{
+		Options: &Options{
+			Domain: "irrelevant",
+			Source: "1.11.0",
+		},
+	}
+
+	err := i.validateConfigurations()
+	require.EqualError(t, err, "You specified one of the --domain, --tlsKey, or --tlsCert without specifying the others. They must be specified together")
+
+	// Domain, certificate, and key are passed
+	i = &Installation{
+		Options: &Options{
+			Domain:  "irrelevant",
+			TLSCert: "fake-cert",
+			TLSKey:  "fake-key",
+			Source:  "1.11.0",
+		},
+	}
+
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Create fake local source path
+	fakePath := "/tmp/fake-path-for-cli-test"
+	i.Options.LocalSrcPath = fakePath
+	err = os.MkdirAll(fakePath+"/installation/resources", 0700)
+	require.NoError(t, err)
+	defer os.RemoveAll(fakePath)
+
+	// Source "local" and local installation
+	i.Options.IsLocal = true
+	i.Options.Source = "local"
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Source "local" and cluster installation, without custom-image
+	i.Options.IsLocal = false
+	i.Options.Source = "local"
+	err = i.validateConfigurations()
+	require.EqualError(t, err, "You must specify --custom-image to install Kyma from local sources to a remote cluster.")
+
+	// Source "local" and cluster installation
+	i.Options.IsLocal = false
+	i.Options.Source = "local"
+	i.Options.CustomImage = "test-registry/test-image:1.0.0"
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Source "latest"
+	i.Options.Source = "latest"
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Source "latest-published"
+	i.Options.Source = "latest-published"
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Source commit id
+	i.Options.Source = "34edf09a"
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Source docker image
+	i.Options.Source = "test-registry/test-image:1.0.0"
+	err = i.validateConfigurations()
+	require.NoError(t, err)
+
+	// Unknown source
+	i.Options.Source = "fake-source"
+	err = i.validateConfigurations()
+	require.Error(t, err)
+}

pkg/installation/upgrade_test.go

@@ -82,12 +82,6 @@ func TestUpgradeKyma(t *testing.T) {
 			OverrideConfigs:  nil,
 			ComponentsConfig: "",
 			IsLocal:          false,
-			LocalCluster: &LocalCluster{
-				IP:       "0.0.0.0",
-				Profile:  "test",
-				Provider: "fake-provider",
-				VMDriver: "fake-driver",
-			},
 		},
 	}
 	// version to upgrade to