This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
Add hashKeyName option for createPersistedQueryLink #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks so much for building such a great library!
apollo-link-persisted-queries
assumes your hash will be sha256, but providesgenerateHash
function to override that which we assumed we’d use to pass our query names. However, It seems strange to send a string likepage.v1
as the hash when it is not sha256.Does that mean I’m using persisted queries in a way they’re not meant to be used or would you accept a PR that allows
createPersistedQueryLink
to take ahashKeyName
to name that key differently?