Extract federation version resolution #2289
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
| pub fn from_supergraph_config( | ||
| self, | ||
| supergraph_config: &SupergraphConfig, | ||
| ) -> FederationVersionResolver<state::FromSubgraphs> { | ||
| let federation_version = self | ||
| .federation_version | ||
| .or(supergraph_config.get_federation_version()); | ||
| FederationVersionResolver { | ||
| state: PhantomData::<state::FromSubgraphs>, | ||
| federation_version, | ||
| } | ||
| } | ||
|
|
||
| /// Skips [`SupergraphConfig`] resolution, presumably because there is none | ||
| pub fn skip_supergraph_resolution(self) -> FederationVersionResolver<state::FromSubgraphs> { | ||
| FederationVersionResolver { | ||
| state: PhantomData::<state::FromSubgraphs>, | ||
| federation_version: self.federation_version, | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it better/is there a way to merge this together into a single step, so we take an Option?
There was a problem hiding this comment.
I merged these, which I think is more consistent with what we do elsewhere.
@jonathanrainer There are tests are in src/composition/supergraph/config/mod.rs from the original supergraph config resolution code that uses this new path. I could migrate that if it makes it more precise to have it hanging out with the FederationResolver source code. |
dotdat
force-pushed
the
dotdat/run-router.extract-federation-resolution
branch
from
3198b6a to
2386d35
Compare
Yer let's do that, just so we're clear what's testing what etc. Happy to approve once that's sorted :) |
dotdat
force-pushed
the
dotdat/run-router.extract-federation-resolution
branch
2 times, most recently
from
e6d6cb8 to
3f916c2
Compare
I extracted the bits of the tests that matter into the federation.rs file, so we should be good to go now. |
dotdat
force-pushed
the
dotdat/run-router.extract-federation-resolution
branch
from
3f916c2 to
a878458
Compare
dotdat
force-pushed
the
dotdat/run-router.extract-federation-resolution
branch
from
a878458 to
c7844ff
Compare
Extracts federation version resolution in order to be used independently of supergraph config