dev/next: log router output #2308
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
| match level { | ||
| "INFO" => tracing::info!(%message), | ||
| "DEBUG" => tracing::debug!(%message), | ||
| "TRACE" => tracing::trace!(%message), | ||
| "WARN" => write!(f, "{} {}", warn_prefix, &message)?, | ||
| "ERROR" => write!(f, "{} {}", error_prefix, &message)?, | ||
| "UNKNOWN" => write!(f, "{} {}", unknown_prefix, &message)?, | ||
| _ => {} |
There was a problem hiding this comment.
I feel like there's some sort of due diligence I could suggest to make sure the level we're setting is right (based on what's in the router, which I've sure you've looked at), but it's sort of escaping me right now; the only thing that sort of worries me is the catch-all at the bottom not emitting anything (but maybe it's better to emit nothing than to emit a bunch of "warning! no level set!" or whatever)
There was a problem hiding this comment.
Even though this is the same as the original implementation
Maybe this should be _ => write!(f, "{} {}", unknown_prefix, &message)??
|
whoa, this got weird after having new commits merged; going to leave the approval, but not totally sure about all the new stuff (going to assume it's alright, but re-request a review if you want a sanity check) |
dotdat
force-pushed
the
loshz/ROVER-251
branch
from
a92a652 to
08b1bbb
Compare
Similar to the legacy implementation, this PR logs output from the running
routerbinary.