⌨️ fix react-hook-form#3363 UnpackNestedValue with extends primitive (r…

…eact-hook-form#3375) * fix react-hook-form#3363 UnpackNestedValue with extends primitive * fix actual issue * remove expect error
appelsinvandi · Nov 6, 2020 · 4724749 · 4724749
1 parent 4c660f8
commit 4724749
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/types/form.ts b/src/types/form.ts
@@ -215,14 +215,15 @@ export type UseFormMethods<TFieldValues extends FieldValues = FieldValues> = {
   ): UnpackNestedValue<DeepPartial<TFieldValues>>;
   setError(name: FieldName<TFieldValues>, error: ErrorOption): void;
   clearErrors(name?: FieldName<TFieldValues> | FieldName<TFieldValues>[]): void;
-  setValue<
-    TFieldName extends string,
-    TFieldValue extends TFieldValues[TFieldName]
-  >(
+  setValue<TFieldName extends string>(
     name: TFieldName,
-    value: TFieldValue extends NestedValue<infer U>
-      ? U
-      : UnpackNestedValue<DeepPartial<LiteralToPrimitive<TFieldValue>>>,
+    value:
+      | FieldValue<TFieldValues>
+      | UnpackNestedValue<DeepPartial<TFieldValues>>
+      | string[]
+      | undefined
+      | null
+      | boolean,
     options?: SetValueConfig,
   ): void;
   trigger(

diff --git a/src/useForm.test.tsx b/src/useForm.test.tsx
@@ -724,12 +724,10 @@ describe('useForm', () => {
 
       result.current.register(elm);
 
-      // @ts-expect-error
       result.current.setValue('test', null);
 
       expect(elm).not.toHaveValue();
 
-      // @ts-expect-error
       result.current.setValue('test', undefined);
 
       expect(elm).not.toHaveValue();