New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve qualified name of types on deprecation replacement #83

Merged

bioball merged 1 commit into apple:main from stackoverflow:improve-replace-with-for-types

Dec 19, 2024

Contributor

stackoverflow commented Dec 5, 2024

This fixes a problem where deprecated imported types where replaced by their unqualified names, leading to wrong code:

// @Deprecated { replaceWith = "ReplaceWith" }
// typealias Deprecated = String
import "foo.pkl"

// `foo.Deprecated` would be replaced with `ReplaceWith`, losing the qualifier
prop: foo.Deprecated

holzensp approved these changes

View reviewed changes


          preserve qualified name of types on deprecation replacement

4c6db27

stackoverflow force-pushed the improve-replace-with-for-types branch from 60cdd08 to 4c6db27 Compare

December 12, 2024 08:31

bioball merged commit f16ef63 into apple:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet