nodejs-express: Shut down Kafka clients when HTTP server is closed (#832

) * nodejs-express: Shut down Kafka clients when HTTP server is closed This PR illustrates how to avoid a hang when running the stack tests where the application makes connections to external services. * Bump version in stack.yaml * Bump stack version Co-authored-by: Neeraj Laad <[email protected]>
appsody · Jun 26, 2020 · 33376d5 · 33376d5
1 parent 9cff0b9
commit 33376d5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/incubator/nodejs-express/stack.yaml b/incubator/nodejs-express/stack.yaml
@@ -1,5 +1,5 @@
 name: Node.js Express
-version: 0.4.11
+version: 0.4.12
 description: Express web framework for Node.js
 license: Apache-2.0
 language: nodejs

diff --git a/incubator/nodejs-express/templates/kafka/app.js b/incubator/nodejs-express/templates/kafka/app.js
@@ -31,8 +31,15 @@ module.exports = (options) => {
     // 'log.connection.close' : false,
   }
 
-  Produce(Kafka, config, log, app);
-  Consume(Kafka, brokers, log);
+  producer = Produce(Kafka, config, log, app);
+  consumer = Consume(Kafka, brokers, log);
+
+  // Disconnect our Kafka clients when the HTTP server is stopped.
+  options.server.on('close', function () {
+    log.info('Disconnecting Kafka clients');
+    producer.disconnect();
+    consumer.disconnect();
+  });
 
   return app;
 };
@@ -89,6 +96,7 @@ function Produce(Kafka, config, log, app) {
 
   // starting the producer
   producer.connect();
+  return producer;
 }
 
 // Based on:
@@ -145,4 +153,5 @@ function Consume(Kafka, brokers, log) {
 
   // starting the consumer
   consumer.connect();
+  return consumer;
 }