Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Remove socket bench #65

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

gregnazario
Copy link
Contributor

Motivation

Remove socket bench, as we won't be maintaining it for now. This is a PR to test out bors

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

None, just cargo x build

@gregnazario gregnazario requested review from davidiw and zekun000 March 4, 2022 01:31
@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for aptos-developer-docs canceled.

🔨 Explore the source changes: cc63fe4

🔍 Inspect the deploy log: https://app.netlify.com/sites/aptos-developer-docs/deploys/6226a4806d42460007039a33

@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

@gregnazario ❗ This PR is still missing approvals, unable to queue for landing

@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

💥 Tests timed-out

@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

💥 Tests timed-out

@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

💥 Tests timed-out

@gregnazario
Copy link
Contributor Author

/land

@gregnazario
Copy link
Contributor Author

/land

1 similar comment
@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

@gregnazario 💡 This PR is already queued for landing

@aptos-bot
Copy link
Contributor

💔 Test Failed - build-test-deploy

@gregnazario
Copy link
Contributor Author

/help

@aptos-bot
Copy link
Contributor

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.

General

  • This project's Merge Queue can be found here.
  • This project requires PRs to be Reviewed and Approved before they can be queued for merging.
  • Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands

Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command Action Description
Land land, merge attempt to land or merge a PR
Canary canary, try canary a PR by performing all checks without merging
Cancel cancel, stop stop an in-progress land
Cherry Pick cherry-pick <target> cherry-pick a PR into <target> branch
Priority priority set the priority level for a PR (high, normal, low)
Help help, h show this help message

Options

Options for Pull Requests are configured through the application of labels.

          Option           Description
label: bors-high-priority Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.
label: bors-low-priority Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.
label: bors-squash Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

1 similar comment
@aptos-bot
Copy link
Contributor

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.

General

  • This project's Merge Queue can be found here.
  • This project requires PRs to be Reviewed and Approved before they can be queued for merging.
  • Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands

Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command Action Description
Land land, merge attempt to land or merge a PR
Canary canary, try canary a PR by performing all checks without merging
Cancel cancel, stop stop an in-progress land
Cherry Pick cherry-pick <target> cherry-pick a PR into <target> branch
Priority priority set the priority level for a PR (high, normal, low)
Help help, h show this help message

Options

Options for Pull Requests are configured through the application of labels.

          Option           Description
label: bors-high-priority Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.
label: bors-low-priority Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.
label: bors-squash Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

@gregnazario 💡 This PR is already queued for landing

@aptos-bot
Copy link
Contributor

❗ Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

@gregnazario
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

@gregnazario 💡 This PR is already queued for landing

@aptos-bot aptos-bot merged commit cc63fe4 into aptos-labs:main Mar 8, 2022
@gregnazario gregnazario deleted the small-fix branch March 10, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants