Skip to content

Commit

Permalink
Expand Phabricator docs slightly
Browse files Browse the repository at this point in the history
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241161 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
Scott Douglass committed Jul 1, 2015
1 parent 2ae3081 commit 7e6843c
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions docs/Phabricator.rst
Original file line number Diff line number Diff line change
Expand Up @@ -60,26 +60,28 @@ to upload your patch):
To upload a new patch:

* Click *Differential*.
* Click *Create Diff*.
* Paste the text diff or upload the patch file.
Note that TODO
* Click *+ Create Diff*.
* Paste the text diff or browse to the patch file. Click *Create Diff*.
* Leave the Repository field blank.
* Leave the drop down on *Create a new Revision...* and click *Continue*.
* Enter a descriptive title and summary. The title and summary are usually
in the form of a :ref:`commit message <commit messages>`.
* Add reviewers and mailing
lists that you want to be included in the review. If your patch is
for LLVM, add llvm-commits as a subscriber; if your patch is for Clang,
for LLVM, add llvm-commits as a Subscriber; if your patch is for Clang,
add cfe-commits.
* Leave the Repository and Project fields blank.
* Click *Save*.

To submit an updated patch:

* Click *Differential*.
* Click *Create Diff*.
* Paste the updated diff.
* Click *+ Create Diff*.
* Paste the updated diff or browse to the updated patch file. Click *Create Diff*.
* Select the review you want to from the *Attach To* dropdown and click
*Continue*.
* Click *Save*.
* Leave the Repository and Project fields blank.
* Add comments about the changes in the new diff. Click *Save*.

Reviewing code with Phabricator
-------------------------------
Expand Down

0 comments on commit 7e6843c

Please sign in to comment.