Skip to content

Commit

Permalink
Clean up calls to WriteBitcodeToFile (NFC)
Browse files Browse the repository at this point in the history
Remove a default parameter value being passed unnecessarily, which
also reduces the changes required when this parameter is changed in
D18763.

Document the remaining non-default bool value passed for another
parameter.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@265348 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
teresajohnson committed Apr 4, 2016
1 parent e393968 commit ee68481
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/LTO/ThinLTOCodeGenerator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ static void saveTempBitcode(const Module &TheModule, StringRef TempDir,
if (EC)
report_fatal_error(Twine("Failed to open ") + SaveTempPath +
" to save optimized bitcode\n");
WriteBitcodeToFile(&TheModule, OS, true, false);
WriteBitcodeToFile(&TheModule, OS, /* ShouldPreserveUseListOrder */ true);
}

bool IsFirstDefinitionForLinker(const GlobalValueInfoList &GVInfo,
Expand Down
2 changes: 1 addition & 1 deletion tools/llvm-lto/llvm-lto.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ static void writeModuleToFile(Module &TheModule, StringRef Filename) {
std::error_code EC;
raw_fd_ostream OS(Filename, EC, sys::fs::OpenFlags::F_None);
error(EC, "error opening the file '" + Filename + "'");
WriteBitcodeToFile(&TheModule, OS, true, false);
WriteBitcodeToFile(&TheModule, OS, /* ShouldPreserveUseListOrder */ true);
}

class ThinLTOProcessing {
Expand Down

0 comments on commit ee68481

Please sign in to comment.