Skip to content

Commit

Permalink
Prevent internal header dependencies from sneaking into external JSI …
Browse files Browse the repository at this point in the history
…headers

Summary:
hermes/hermes.h should not depend on VM internals.  Remove
GCExecTrace.h, and replace it with a forward declaration.

To prevent this from happening in the future, refactor the
hermes_api_library macro to remove include:include from exported_deps.

Reviewed By: dulinriley

Differential Revision: D21308540

fbshipit-source-id: 4685c247518162e9108f259d808a8b2c4f0b2044
  • Loading branch information
mhorowitz authored and facebook-github-bot committed May 1, 2020
1 parent e777784 commit cdc4ea7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion API/hermes/hermes.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <string>

#include <hermes/Public/RuntimeConfig.h>
#include <hermes/VM/GCExecTrace.h>
#include <jsi/jsi.h>

struct HermesTestHelper;
Expand All @@ -25,6 +24,7 @@ class raw_ostream;

namespace hermes {
namespace vm {
class GCExecTrace;
struct MockedEnvironment;
} // namespace vm
} // namespace hermes
Expand Down

0 comments on commit cdc4ea7

Please sign in to comment.