Skip to content

Commit

Permalink
[expo-manifests] Fix error in handling nested array (expo#23562)
Browse files Browse the repository at this point in the history
# Why

Fix crash on iOS if a plugin is passed in as an array, but with only the
name element and not the props element.

Also fix corresponding code on Android, where an exception is thrown.

Fixes expo#23549.

# How

Modified `Manifest.swift` and `Manifest.kt` to handle the above case
correctly.

# Test Plan

- Tested with Expo Go and the project provided in the above issue
- New unit tests for both iOS and Android

# Checklist

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
  • Loading branch information
douglowder authored Jul 19, 2023
1 parent c5a8724 commit 1902997
Show file tree
Hide file tree
Showing 9 changed files with 231 additions and 201 deletions.
4 changes: 4 additions & 0 deletions apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1902997

Please sign in to comment.