tweaks to unit tests after adding :parameters attribute to Card

aq · Jun 15, 2016 · 4a12782 · 4a12782
1 parent bb026bf
commit 4a12782
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 2 deletions.
diff --git a/test/metabase/api/card_test.clj b/test/metabase/api/card_test.clj
@@ -187,6 +187,7 @@
      :id                     $
      :display                "table"
      :visualization_settings {}
+     :parameters             []
      :public_perms           0
      :created_at             $
      :database_id            database-id ; these should be inferred from the dataset_query
@@ -200,7 +201,12 @@
 
 ;; updating a card that doesn't exist should give a 404
 (expect "Not found."
-  ((user->client :crowberto) :put 404 "card/12345"))
+  ((user->client :crowberto) :put 404 "card/12345" {:name                   "Blah"
+                                                    :display                "table"
+                                                    :public_perms           0
+                                                    :parameters             []
+                                                    :dataset_query          {}
+                                                    :visualization_settings {}}))
 
 ;; Test that we can edit a Card
 (let [updated-name (random-name)]
@@ -222,7 +228,13 @@
   (with-temp-card [{:keys [id]}]
     (let [archived?     (fn [] (:archived (Card id)))
           set-archived! (fn [archived]
-                          ((user->client :rasta) :put 200 (str "card/" id) {:archived archived})
+                          ((user->client :rasta) :put 200 (str "card/" id) {:archived               archived
+                                                                            :name                   "Blah"
+                                                                            :display                "table"
+                                                                            :public_perms           0
+                                                                            :parameters             []
+                                                                            :dataset_query          {}
+                                                                            :visualization_settings {}})
                           (archived?))]
       [(archived?)
        (set-archived! true)

diff --git a/test/metabase/api/dashboard_test.clj b/test/metabase/api/dashboard_test.clj
@@ -125,6 +125,7 @@
                                            :query_type             nil
                                            :dataset_query          {}
                                            :visualization_settings {}
+                                           :parameters             []
                                            :archived               false}
                       :series              []}]
    :organization_id nil}

diff --git a/test/metabase/api/dataset_test.clj b/test/metabase/api/dataset_test.clj
@@ -145,6 +145,7 @@
                                              (ql/aggregation (ql/count))))
                                          (assoc :type "query")
                                          (assoc-in [:query :aggregation] {:aggregation-type "count"}))
+             :parameters             []
              :visualization_settings {}
              :created_at             true
              :updated_at             true

diff --git a/test/metabase/api/pulse_test.clj b/test/metabase/api/pulse_test.clj
@@ -22,6 +22,7 @@
     :public_perms           common/perms-readwrite
     :display                "table"
     :dataset_query          {}
+    :parameters             []
     :visualization_settings {}))
 
 (defn- new-pulse! [& {:keys [name cards channels]

diff --git a/test/metabase/events/activity_feed_test.clj b/test/metabase/events/activity_feed_test.clj
@@ -44,6 +44,7 @@
                     :dataset_query          {:database (id)
                                              :type     :query
                                              :query    {:source_table (id :categories)}}
+                    :parameters             []
                     :visualization_settings {})
         dashcard  (db/insert! DashboardCard
                     :card_id      (:id card)

diff --git a/test/metabase/events/revision_test.clj b/test/metabase/events/revision_test.clj
@@ -28,6 +28,7 @@
                                :type     "query"
                                :query    {:aggregation ["rows"]
                                           :source_table (id :categories)}}
+      :parameters             []
       :visualization_settings {}
       :creator_id             (user->id :crowberto))))
 
@@ -43,6 +44,7 @@
    :id                     (:id card)
    :display                "table"
    :visualization_settings {}
+   :parameters             []
    :public_perms           2
    :archived               false})
 

diff --git a/test/metabase/test/util.clj b/test/metabase/test/util.clj
@@ -118,6 +118,7 @@
                                 :dataset_query          {}
                                 :display                :table
                                 :name                   (random-name)
+                                :parameters             []
                                 :public_perms           common/perms-none
                                 :visualization_settings {}})})