Skip to content

Commit

Permalink
Revert "drm/qxl: do not run release if qxl failed to init"
Browse files Browse the repository at this point in the history
This reverts commit b91907a.

Patch is broken, it effectively makes qxl_drm_release() a nop
because on normal driver shutdown qxl_drm_release() is called
*after* drm_dev_unregister().

Fixes: b91907a ("drm/qxl: do not run release if qxl failed to init")
Cc: Tong Zhang <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Acked-by: Thomas Zimmermann <[email protected]>
Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
kraxel committed Feb 5, 2021
1 parent 6fec777 commit 93d8da8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/gpu/drm/qxl/qxl_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ static void qxl_drm_release(struct drm_device *dev)
* reodering qxl_modeset_fini() + qxl_device_fini() calls is
* non-trivial though.
*/
if (!dev->registered)
return;
qxl_modeset_fini(qdev);
qxl_device_fini(qdev);
}
Expand Down

0 comments on commit 93d8da8

Please sign in to comment.