Skip to content

Commit

Permalink
arm64: dts: qcom: pmi8994: Remove hardcoded linear WLED enabled-strings
Browse files Browse the repository at this point in the history
The driver now sets an appropriate default for WLED4 (and WLED5) just
like WLED3 making this linear array from 0-3 redundant.  In addition the
driver is now able to parse arrays of variable length solving the "all
four strings *have to* be defined" comment.

Besides the driver will now warn when both properties are specified to
prevent ambiguity: the length of the array is enough to imply a set
number of strings.

Signed-off-by: Marijn Suijten <[email protected]>
Reviewed-By: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
MarijnS95 authored and andersson committed Oct 24, 2021
1 parent b110dfa commit 9b729b0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions arch/arm64/boot/dts/qcom/pmi8994.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
interrupts = <3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
interrupt-names = "short";
qcom,num-strings = <3>;
/* Yes, all four strings *have to* be defined or things won't work. */
qcom,enabled-strings = <0 1 2 3>;
qcom,cabc;
qcom,external-pfet;
status = "disabled";
Expand Down

0 comments on commit 9b729b0

Please sign in to comment.