Skip to content

Commit

Permalink
arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size
Browse files Browse the repository at this point in the history
[ Upstream commit 2aa54fa ]

These voltages are not a multiple of the given step-size 8000 (with base
voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and
l22 failing to validate and in turn not probing the rpm-pm8998-regulator
driver:

    l18: unsupportable voltage constraints 2856000-2848000uV
    qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22

Round the voltages down for the sake of erring on the safe side, leaving
a comment in place to document this discrepancy wrt downstream sources.

Fixes: 390883a ("arm64: dts: qcom: msm8998: Introduce support for Sony Yoshino platform")
Reported-by: Konrad Dybcio <[email protected]>
Signed-off-by: Marijn Suijten <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Sasha Levin <[email protected]>
  • Loading branch information
MarijnS95 authored and gregkh committed Aug 17, 2022
1 parent 51dabf1 commit fd95595
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@
};

&vreg_l18a_2p85 {
regulator-min-microvolt = <2850000>;
regulator-max-microvolt = <2850000>;
/* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */
regulator-min-microvolt = <2848000>;
regulator-max-microvolt = <2848000>;
};

&vreg_l22a_2p85 {
regulator-min-microvolt = <2700000>;
regulator-max-microvolt = <2700000>;
/* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */
regulator-min-microvolt = <2696000>;
regulator-max-microvolt = <2696000>;
};

0 comments on commit fd95595

Please sign in to comment.