Updates from Wed Feb 25

- [react-packager] Fix lint errors | Amjad Masad
- [react-packager] fix a typo s/pacakge/package | Chengyin Liu
- [react-packager] Fix jest tests | Amjad Masad
- [Image] Really improve the quality of mis-sized images w/trilinear filtering | James Ide

.eslintrc

@@ -21,15 +21,16 @@
     "Map": true,
     "module": false,
     "process": false,
-    "Promise": false,
+    "Promise": true,
     "requestAnimationFrame": true,
     "require": false,
     "Set": true,
     "setImmediate": true,
     "setInterval": false,
     "setTimeout": false,
     "window": false,
-    "XMLHttpRequest": false
+    "XMLHttpRequest": false,
+    "pit": false
   },
 
   "rules": {
@@ -148,7 +149,7 @@
     "no-multi-spaces": 0,
     "brace-style": 0,                // enforce one true brace style (off by default)
     "camelcase": 0,                  // require camel case names
-    "consistent-this": 1,            // enforces consistent naming when capturing the current execution context (off by default)
+    "consistent-this": [1, "self"],            // enforces consistent naming when capturing the current execution context (off by default)
     "eol-last": 1,                   // enforce newline at the end of file, with no multiple empty lines
     "func-names": 0,                 // require function expressions to have a name (off by default)
     "func-style": 0,                 // enforces use of function declarations or expressions (off by default)

ReactKit/Views/RCTNetworkImageView.m

@@ -52,6 +52,8 @@ - (void)setImageURL:(NSURL *)imageURL resetToDefaultImageWhileLoading:(BOOL)rese
     if (reset) {
       self.layer.contentsScale = _defaultImage.scale;
       self.layer.contents = (__bridge id)_defaultImage.CGImage;
+      self.layer.minificationFilter = kCAFilterTrilinear;
+      self.layer.magnificationFilter = kCAFilterTrilinear;
     }
     if ([imageURL.pathExtension caseInsensitiveCompare:@"gif"] == NSOrderedSame) {
       _downloadToken = [_imageDownloader downloadDataForURL:imageURL block:^(NSData *data, NSError *error) {
@@ -61,6 +63,8 @@ - (void)setImageURL:(NSURL *)imageURL resetToDefaultImageWhileLoading:(BOOL)rese
           self.layer.bounds = CGRectMake(0, 0, CGImageGetWidth(firstFrame), CGImageGetHeight(firstFrame));
           self.layer.contentsScale = 1.0;
           self.layer.contentsGravity = kCAGravityResizeAspect;
+          self.layer.minificationFilter = kCAFilterLinear;
+          self.layer.magnificationFilter = kCAFilterLinear;
           [self.layer addAnimation:animation forKey:@"contents"];
         }
         // TODO: handle errors

ReactKit/Views/RCTStaticImage.m

@@ -20,6 +20,10 @@ - (void)_updateImage
   if (!UIEdgeInsetsEqualToEdgeInsets(UIEdgeInsetsZero, _capInsets)) {
     image = [image resizableImageWithCapInsets:_capInsets resizingMode:UIImageResizingModeStretch];
   }
+
+  // Apply trilinear filtering to smooth out mis-sized images
+  self.layer.minificationFilter = kCAFilterTrilinear;
+  self.layer.magnificationFilter = kCAFilterTrilinear;
 
   super.image = image;
 }

jestSupport/env.js

@@ -0,0 +1,5 @@
+'use strict';
+
+global.setImmediate = global.setImmediate || function(fn) {
+  return setTimeout(fn, 0);
+};

jestSupport/scriptPreprocess.js

@@ -10,6 +10,10 @@ module.exports = {
   transformSource: transformSource,
 
   process: function(src, fileName) {
+    if (fileName.match(/node_modules/)) {
+      return src;
+    }
+
     try {
       return transformSource(src);
     } catch(e) {

package.json

@@ -1,19 +1,22 @@
 {
   "name": "react-native",
-  "version": "0.0.1",
+  "version": "0.1.0",
   "description": "Build native apps with React!",
   "repository": {
     "type": "git",
     "url": "[email protected]:facebook/react-native.git"
   },
   "jest": {
     "scriptPreprocessor": "jestSupport/scriptPreprocess.js",
+    "setupEnvScriptFile": "jestSupport/env.js",
     "testPathIgnorePatterns": [
-      "/node_modules/",
-      "/packager/"
+      "/node_modules/"
     ],
     "testFileExtensions": [
       "js"
+    ],
+    "unmockedModulePathPatterns": [
+      "source-map"
     ]
   },
   "scripts": {

packager/react-packager/src/Activity/__tests__/Activity-test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 jest.autoMockOff();
 
 describe('Activity', function() {

packager/react-packager/src/Activity/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var COLLECTION_PERIOD = 1000;
 
 var _endedEvents = Object.create(null);

packager/react-packager/src/DependencyResolver/ModuleDescriptor.js

@@ -1,3 +1,5 @@
+'use strict';
+
 function ModuleDescriptor(fields) {
   if (!fields.id) {
     throw new Error('Missing required fields id');
@@ -28,7 +30,7 @@ ModuleDescriptor.prototype.toJSON = function() {
     id: this.id,
     path: this.path,
     dependencies: this.dependencies
-  }
+  };
 };
 
 module.exports = ModuleDescriptor;