forked from greenplum-db/gpbackup-archive
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-6342: Refactor gprestore helper oidWithBatchList #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stolb27
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB! We don't merge this patch before SRS for dependent improvement will be accepted.
whitehawk
reviewed
Sep 30, 2024
whitehawk
reviewed
Sep 30, 2024
whitehawk
reviewed
Sep 30, 2024
whitehawk
reviewed
Sep 30, 2024
whitehawk
reviewed
Sep 30, 2024
whitehawk
reviewed
Sep 30, 2024
whitehawk
previously approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor gprestore helper oidWithBatchList
Currently, gprestore helper has one loop over the list of tables with already
defined batches. This creates difficulties for moving to the next table when a
skip file is detected. Also, such a loop is not easy to parallelize so that all
batches of the same table are processed sequentially by the same
process/thread. Therefore, this patch offers refactoring of the list and one
loop with division into two loops: an outer loop over tables and an inner loop
over batches. Now, one table is found only once in the list, and the second
argument is not the batch number, as it was before, but the number of batches
for the table (for replicated tables, one batch is always used). Also, the main
process pre-creates pipes only for the first batches. The logic for processing
skip files has also been significantly simplified.
It is easier to view the changes with the "Hide whitespace" option enabled.