gppkg: remove special Concourse task for GPHOME copying

concourse/scripts/gppkg_behave.sh, which installs an identical copy of
GPHOME into a new location, existed for exactly one test. Modify that
test to perform its own copy-install.

(cherry picked from commit e6b40a7)

concourse/pipelines/gpdb_6X_STABLE-generated.yml

@@ -18,8 +18,6 @@
 ## Test Sections: ['ICW', 'Replication', 'ResourceGroups', 'Interconnect', 'CLI', 'UD', 'AA', 'Extensions', 'Gpperfmon']
 ## ======================================================================
 
-
-
 ## ======================================================================
 ##   __ _ _ __ ___  _   _ _ __  ___
 ##  / _` | '__/ _ \| | | | '_ \/ __|
@@ -1543,7 +1541,6 @@ jobs:
             <<: *ccp_gen_cluster_default_params
         - task: gpinitsystem
           file: ccp_src/ci/tasks/gpinitsystem.yml
-
         - task: gpmovemirrors_concourse_cluster_tests
           file: gpdb_src/concourse/tasks/run_behave.yml
           image: ccp-image
@@ -1614,11 +1611,6 @@ jobs:
             <<: *ccp_gen_cluster_default_params
         - task: gpinitsystem
           file: ccp_src/ci/tasks/gpinitsystem.yml
-
-        - task: setup_gppkg_second_install
-          file: gpdb_src/concourse/tasks/gppkg_behave.yml
-          params:
-            SECOND_BINARY_INSTALL_LOCATION: /tmp/gppkg_migrate
         - task: gppkg_concourse_cluster_tests
           file: gpdb_src/concourse/tasks/run_behave.yml
           image: ccp-image
@@ -1794,7 +1786,6 @@ jobs:
             <<: *ccp_gen_cluster_default_params
         - task: gpinitsystem
           file: ccp_src/ci/tasks/gpinitsystem.yml
-
         - task: gpcheckcat_concourse_cluster_tests
           file: gpdb_src/concourse/tasks/run_behave.yml
           image: ccp-image
@@ -1844,7 +1835,6 @@ jobs:
             <<: *ccp_gen_cluster_default_params
         - task: gpinitsystem
           file: ccp_src/ci/tasks/gpinitsystem.yml
-
         - task: gprecoverseg_concourse_cluster_tests
           file: gpdb_src/concourse/tasks/run_behave.yml
           image: ccp-image
@@ -1894,7 +1884,6 @@ jobs:
             <<: *ccp_gen_cluster_default_params
         - task: gpinitsystem
           file: ccp_src/ci/tasks/gpinitsystem.yml
-
         - task: gpaddmirrors_concourse_cluster_tests
           file: gpdb_src/concourse/tasks/run_behave.yml
           image: ccp-image

concourse/pipelines/templates/gpdb-tpl.yml

@@ -1,20 +1,11 @@
-
-{% set gppkg_additional_task = "
-        - task: setup_gppkg_second_install
-          file: gpdb_src/concourse/tasks/gppkg_behave.yml
-          params:
-            SECOND_BINARY_INSTALL_LOCATION: /tmp/gppkg_migrate"
-%}
-
 {% set CLI_BEHAVE_TESTS = [
                       {'name': 'gpmovemirrors',
                        'use_concourse_cluster': true,
                        'additional_ccp_vars': 'number_of_nodes: 4'},
                       {'name': 'gpcheck',
                        'use_concourse_cluster': false},
                       {'name': 'gppkg',
-                       'use_concourse_cluster': true,
-                       'additional_tasks': gppkg_additional_task},
+                       'use_concourse_cluster': true},
                       {'name': 'analyzedb',
                        'use_concourse_cluster': false},
                       {'name': 'gpinitsystem',
@@ -1776,7 +1767,6 @@ jobs:
             <<: *ccp_gen_cluster_default_params
         - task: gpinitsystem
           file: ccp_src/ci/tasks/gpinitsystem.yml
-        [[ test.additional_tasks ]]
         - task: [[ test.name ]]_concourse_cluster_tests
           file: gpdb_src/concourse/tasks/run_behave.yml
           image: ccp-image

gpMgmt/test/behave/mgmt_utils/gppkg.feature

@@ -120,6 +120,7 @@ Feature: gppkg tests
     Scenario: gppkg --migrate copies all packages from master to all segment hosts
         Given the database is running
         And the user runs "gppkg -r sample"
+        And a gphome copy is created at /tmp/gppkg_migrate on all hosts
         When a user runs "MASTER_DATA_DIRECTORY=$MASTER_DATA_DIRECTORY gppkg -r sample" with gphome "/tmp/gppkg_migrate"
         And "sample" gppkg files do not exist on any hosts
         When a user runs "MASTER_DATA_DIRECTORY=$MASTER_DATA_DIRECTORY gppkg --install $(pwd)/test/behave/mgmt_utils/steps/data/sample.gppkg" with gphome "/tmp/gppkg_migrate"

gpMgmt/test/behave/mgmt_utils/steps/mgmt_utils.py

@@ -1941,6 +1941,47 @@ def impl(context, gppkg_name):
 def impl(context, gppkg_name):
     _remove_gppkg_from_host(context, gppkg_name, is_master_host=True)
 
+
+@given('a gphome copy is created at {location} on all hosts')
+def impl(context, location):
+    """
+    Copies the contents of GPHOME from the local machine into a different
+    directory location for all hosts in the cluster.
+    """
+    gphome = os.environ["GPHOME"]
+    greenplum_path = path.join(gphome, 'greenplum_path.sh')
+
+    # First replace the GPHOME envvar in greenplum_path.sh.
+    subprocess.check_call([
+        'sed',
+        '-i.bak', # we use this backup later
+        '-e', r's|^GPHOME=.*$|GPHOME={}|'.format(location),
+        greenplum_path,
+    ])
+
+    try:
+        # Now copy all the files over.
+        hosts = set(get_all_hostnames_as_list(context, 'template1'))
+
+        host_opts = []
+        for host in hosts:
+            host_opts.extend(['-h', host])
+
+        subprocess.check_call([
+            'gpscp',
+            '-rv',
+            ] + host_opts + [
+            os.getenv('GPHOME'),
+            '=:{}'.format(location),
+        ])
+
+    finally:
+        # Put greenplum_path.sh back the way it was.
+        subprocess.check_call([
+            'mv', '{}.bak'.format(greenplum_path), greenplum_path
+        ])
+
+
 @then('gpAdminLogs directory has no "{expected_file}" files')
 def impl(context, expected_file):
     log_dir = _get_gpAdminLogs_directory()