Extract method

arenadata · Aug 16, 2024 · 59884cc · 59884cc
1 parent a9876b5
commit 59884cc
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/...va/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java b/...va/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
@@ -1465,8 +1465,6 @@ private void createStageExecution(
                         sinkPartitioningScheme.getPartitionCount(),
                         preserveOrderWithinPartition));
 
-                boolean coordinatorStage = stage.getFragment().getPartitioning().equals(COORDINATOR_DISTRIBUTION);
-
                 if (eager) {
                     sourceExchanges.values().forEach(sourceExchange -> sourceExchange.setSourceHandlesDeliveryMode(EAGER));
                 }
@@ -1493,7 +1491,7 @@ private void createStageExecution(
                         memoryEstimatorFactory.createPartitionMemoryEstimator(session, fragment, planFragmentLookup),
                         outputStatsEstimator,
                         // do not retry coordinator only tasks
-                        coordinatorStage ? 1 : maxTaskExecutionAttempts,
+                        shouldRetry(stage) ? maxTaskExecutionAttempts : 1,
                         schedulingPriority,
                         eager,
                         speculative,
@@ -1518,6 +1516,12 @@ private void createStageExecution(
             }
         }
 
+        private static boolean shouldRetry(SqlStage stage)
+        {
+            boolean coordinatorStage = stage.getFragment().getPartitioning().equals(COORDINATOR_DISTRIBUTION);
+            return !coordinatorStage;
+        }
+
         private StageId getStageId(PlanFragmentId fragmentId)
         {
             return StageId.create(queryStateMachine.getQueryId(), fragmentId);