Log stage memory estimation on task failure

arenadata · Aug 19, 2024 · 6495054 · 6495054
1 parent 5d64b72
commit 6495054
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/...va/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java b/...va/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
@@ -2463,13 +2463,18 @@ public List<PrioritizedScheduledTask> taskFailed(TaskId taskId, ExecutionFailure
                     taskStatus.getPeakMemoryReservation(),
                     errorCode);
             partition.setPostFailureMemoryRequirements(newMemoryLimits);
-            log.debug(
-                    "Computed next memory requirements for task from stage %s; previous=%s; new=%s; peak=%s; estimator=%s",
-                    stage.getStageId(),
-                    currentMemoryLimits,
-                    newMemoryLimits,
-                    taskStatus.getPeakMemoryReservation(),
-                    partitionMemoryEstimator);
+
+            if (errorCode != null && isOutOfMemoryError(errorCode)) {
+                log.info(
+                        "Computed next memory requirements for tasks from %s.%s; previous=%s; new=%s; peak=%s; estimator=%s; failingTask=%s",
+                        stage.getStageId(),
+                        partitionId,
+                        currentMemoryLimits,
+                        newMemoryLimits,
+                        taskStatus.getPeakMemoryReservation(),
+                        partitionMemoryEstimator,
+                        taskId);
+            }
 
             if (errorCode != null && isOutOfMemoryError(errorCode) && newMemoryLimits.getRequiredMemory().toBytes() * 0.99 <= taskStatus.getPeakMemoryReservation().toBytes()) {
                 String message = format(