-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGE] Restructure Swift Package #376
Open
dioKaratzas
wants to merge
8
commits into
develop
Choose a base branch
from
improvement/optimize-project
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dioKaratzas
commented
Aug 14, 2024
- Moved source files to Sources/Web3Swift
- Moved test files to Tests/Web3SwiftTests
- Moved libs on root
- Moved ZKSync source files to Sources/Web3ZkSync
- Moved source files to Sources/Web3Swift - Moved test files to Tests/Web3SwiftTests - Moved libs on root - Moved ZKSync source files to Sources/Web3ZkSync
dioKaratzas
force-pushed
the
improvement/optimize-project
branch
2 times, most recently
from
August 14, 2024 16:34
6e1d719
to
e7e4350
Compare
dioKaratzas
commented
Sep 23, 2024
.package(name: "BigInt", url: "https://github.com/attaswift/BigInt", from: "5.3.0"), | ||
.package(name: "GenericJSON", url: "https://github.com/iwill/generic-json-swift", .upToNextMajor(from: "2.0.0")), | ||
.package(url: "https://github.com/GigaBitcoin/secp256k1.swift.git", .upToNextMajor(from: "0.6.0")), | ||
.package(url: "https://github.com/attaswift/BigInt", exact: "5.3.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XCTAssertEqual(BigInt(hex: "")!, 0)
when updating to latest BigInt that assert fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.