minor tweaks

ariofrio · Jan 9, 2012 · f721672 · f721672
1 parent c8368c8
commit f721672
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/bean.js b/bean.js
@@ -27,6 +27,7 @@
     , W3C_MODEL = root[addEvent]
     , eventSupport = W3C_MODEL ? addEvent : attachEvent
     , slice = Array.prototype.slice
+    , mouseTypeRegex = /click|mouse|menu|drag|drop/i
     , ONE = { one: 1 } // singleton for quick matching making add() do one()
 
     , nativeEvents = (function (hash, events, i) {
@@ -137,7 +138,7 @@
             if (type.indexOf('key') !== -1) {
               props = keyProps
               result.keyCode = event.which || event.keyCode
-            } else if ((/click|mouse|menu|drag|drop/i).test(type)) {
+            } else if (mouseTypeRegex.test(type)) {
               props = mouseProps
               result.rightClick = event.which === 3 || event.button === 2
               result.pos = { x: 0, y: 0 }
@@ -217,7 +218,7 @@
               if (!type || type === '*') {
                 // search the whole registry
                 for (var t in map) {
-                  if (t[0] === '$')
+                  if (t.charAt(0) === '$')
                     forAll(element, t.substr(1), original, handler, fn)
                 }
               } else {
@@ -269,7 +270,7 @@
           , entries = function () {
               var t, entries = []
               for (t in map) {
-                if (t[0] === '$')
+                if (t.charAt(0) === '$')
                   entries = entries.concat(map[t])
               }
               return entries

diff --git a/bean.min.js b/bean.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "bean",
   "description": "an events api for javascript",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "homepage": "https://github.com/fat/bean",
   "authors": ["Jacob Thornton <@fat>", "Dustin Diaz <@ded>", "Rod Vagg <@rvagg>"],
   "repository": {

diff --git a/src/bean.js b/src/bean.js
@@ -18,6 +18,7 @@
     , W3C_MODEL = root[addEvent]
     , eventSupport = W3C_MODEL ? addEvent : attachEvent
     , slice = Array.prototype.slice
+    , mouseTypeRegex = /click|mouse|menu|drag|drop/i
     , ONE = { one: 1 } // singleton for quick matching making add() do one()
 
     , nativeEvents = (function (hash, events, i) {
@@ -128,7 +129,7 @@
             if (type.indexOf('key') !== -1) {
               props = keyProps
               result.keyCode = event.which || event.keyCode
-            } else if ((/click|mouse|menu|drag|drop/i).test(type)) {
+            } else if (mouseTypeRegex.test(type)) {
               props = mouseProps
               result.rightClick = event.which === 3 || event.button === 2
               result.pos = { x: 0, y: 0 }
@@ -208,7 +209,7 @@
               if (!type || type === '*') {
                 // search the whole registry
                 for (var t in map) {
-                  if (t[0] === '$')
+                  if (t.charAt(0) === '$')
                     forAll(element, t.substr(1), original, handler, fn)
                 }
               } else {
@@ -260,7 +261,7 @@
           , entries = function () {
               var t, entries = []
               for (t in map) {
-                if (t[0] === '$')
+                if (t.charAt(0) === '$')
                   entries = entries.concat(map[t])
               }
               return entries