Don't lint HexValidation on mid-word hex strings

arithmetric · Sep 28, 2015 · 0a9f024 · 0a9f024
1 parent c435e2a
commit 0a9f024
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/scss_lint/linter/hex_validation.rb b/lib/scss_lint/linter/hex_validation.rb
@@ -6,7 +6,7 @@ class Linter::HexValidation < Linter
     def visit_script_string(node)
       return unless node.type == :identifier
 
-      node.value.scan(/(#\h+)/) do |match|
+      node.value.scan(/(?:\W|^)(#\h+)(?:\W|$)/) do |match|
         check_hex(match.first, node)
       end
     end

diff --git a/spec/scss_lint/linter/hex_validation_spec.rb b/spec/scss_lint/linter/hex_validation_spec.rb
@@ -37,4 +37,15 @@
     it { should report_lint line: 2 }
     it { should report_lint line: 3 }
   end
+
+  context 'when rule contains hex codes in a longer string' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: 'foo#bad';
+        content: 'foo #ba';
+      }
+    SCSS
+
+    it { should report_lint line: 3 }
+  end
 end