fix: avoid cloning accessor properties #1305
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore accessor properties to prevent assigning a “value” field when a getter or setter exists
This is my first pr, so please tell me if i missed someting.
This pr prevents the error "TypeError: Invalid property. 'value' present on property with getter or setter." when trying to parse an object with a getter or setter.
As an example, you would need to pass process.env with an spread operator({ process.env }) so it could be validated and not throw an error by the lib. With this fix, now it can be validated correctly without the spread operator.
I think the test "can clone process.env" at clone.test.ts might need to be changed to reflect this new behavior.