Option to ignore interface declarations in the Semicolon rule (palant…

…ir#1233)

src/rules/semicolonRule.ts

@@ -20,6 +20,7 @@ import * as Lint from "../lint";
 
 const OPTION_ALWAYS = "always";
 const OPTION_NEVER = "never";
+const OPTION_IGNORE_INTERFACES = "ignore-interfaces";
 
 export class Rule extends Lint.Rules.AbstractRule {
     public static FAILURE_STRING_MISSING = "missing semicolon";
@@ -91,6 +92,10 @@ class SemicolonWalker extends Lint.RuleWalker {
     }
 
     public visitInterfaceDeclaration(node: ts.InterfaceDeclaration) {
+        if (this.hasOption(OPTION_IGNORE_INTERFACES)) {
+            return;
+        }
+
         for (let member of node.members) {
             this.checkSemicolonAt(member);
         }

src/tsconfig.json

@@ -85,8 +85,8 @@
         "rules/noConditionalAssignmentRule.ts",
         "rules/noConsecutiveBlankLinesRule.ts",
         "rules/noConsoleRule.ts",
-        "rules/noConstructRule.ts",
         "rules/noConstructorVarsRule.ts",
+        "rules/noConstructRule.ts",
         "rules/noDebuggerRule.ts",
         "rules/noDefaultExportRule.ts",
         "rules/noDuplicateKeyRule.ts",

test/rules/semicolon/enabled/test.ts.lint

@@ -58,6 +58,7 @@ class MyClass {
     private index : number
                           ~nil [missing semicolon]
     private email : string;
+
     public initializedProperty = 6
                                   ~nil [missing semicolon]
     public initializedMethodProperty = () => { return "hi"; }
@@ -79,7 +80,6 @@ import {Controller} from 'my-lib'
 export default LoginPage;
 export default LoginPage
                         ~nil [missing semicolon]
-
 export = Date;
 export = Date
              ~nil [missing semicolon]

test/rules/semicolon/ignore-interfaces/test.ts.lint

@@ -0,0 +1,85 @@
+var x = 3
+         ~nil [missing semicolon]
+a += b
+      ~nil [missing semicolon]
+
+c = () => {
+}
+ ~nil [missing semicolon]
+
+d = function() { }
+                  ~nil [missing semicolon]
+
+console.log("i am adam, am i?")
+                               ~nil [missing semicolon]
+
+function xyz() {
+    return
+          ~nil [missing semicolon]
+}
+
+switch(xyz) {
+    case 1:
+        break
+             ~nil [missing semicolon]
+    case 2:
+        continue
+                ~nil [missing semicolon]
+}
+
+throw new Error("some error")
+                             ~nil [missing semicolon]
+
+do {
+    var a = 4
+             ~nil [missing semicolon]
+} while(x == 3)
+               ~nil [missing semicolon]
+
+debugger
+        ~nil [missing semicolon]
+
+import v = require("i")
+                       ~nil [missing semicolon]
+module M {
+    export var x
+                ~nil [missing semicolon]
+}
+
+function useStrictMissingSemicolon() {
+    "use strict"
+                ~nil [missing semicolon]
+    return null;
+}
+
+class MyClass {
+    public name : string
+                        ~nil [missing semicolon]
+    private index : number
+                          ~nil [missing semicolon]
+    private email : string;
+
+    public initializedProperty = 6
+                                  ~nil [missing semicolon]
+    public initializedMethodProperty = () => { return "hi"; }
+}
+
+interface ITest {
+    foo?: string
+
+    bar: number
+
+    baz: boolean;
+}
+
+import {Router} from 'aurelia-router';
+
+import {Controller} from 'my-lib'
+                                 ~nil [missing semicolon]
+
+export default LoginPage;
+export default LoginPage
+                        ~nil [missing semicolon]
+export = Date;
+export = Date
+             ~nil [missing semicolon]

test/rules/semicolon/ignore-interfaces/tslint.json

@@ -0,0 +1,5 @@
+{
+    "rules": {
+        "semicolon": [true, "always", "ignore-interfaces"]
+    }
+}

test/tsconfig.json

@@ -82,8 +82,8 @@
         "../src/rules/noConditionalAssignmentRule.ts",
         "../src/rules/noConsecutiveBlankLinesRule.ts",
         "../src/rules/noConsoleRule.ts",
-        "../src/rules/noConstructRule.ts",
         "../src/rules/noConstructorVarsRule.ts",
+        "../src/rules/noConstructRule.ts",
         "../src/rules/noDebuggerRule.ts",
         "../src/rules/noDefaultExportRule.ts",
         "../src/rules/noDuplicateKeyRule.ts",