Skip to content

Commit

Permalink
Document SyncPoint::LoadDependency (facebook#11477)
Browse files Browse the repository at this point in the history
Summary:
It's easy to mix up the ordering when it's undocumented. For an example of the meaning of the order, see DBTest.ThreadStatusFlush.

Pull Request resolved: facebook#11477

Test Plan: comments only

Reviewed By: jaykorean

Differential Revision: D46166683

Pulled By: pdillinger

fbshipit-source-id: 33118ba7ef1b08eab7b077548fe2e70f2c309e3f
  • Loading branch information
pdillinger authored and facebook-github-bot committed May 24, 2023
1 parent 17bc277 commit e871030
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test_util/sync_point.h
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ class SyncPoint {
};

// call once at the beginning of a test to setup the dependency between
// sync points
// sync points. Specifically, execution will not be allowed to proceed past
// each successor until execution has reached the corresponding predecessor,
// in any thread.
void LoadDependency(const std::vector<SyncPointPair>& dependencies);

// call once at the beginning of a test to setup the dependency between
Expand Down

0 comments on commit e871030

Please sign in to comment.